core: deprecate CoreAPI.Dht, introduce CoreAPI.Routing #10329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacdias
changed the title
hacdias
changed the title
hacdias
changed the title
hacdias
force-pushed
the
routing-coreapi
branch
from
8e474db
to
2f62ff6
Compare
hacdias
force-pushed
the
routing-coreapi
branch
2 times, most recently
from
3357e5f
to
9365b3a
Compare
hacdias
force-pushed
the
routing-coreapi
branch
from
9365b3a
to
50caaf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses some notes in #10265 (comment):
CoreAPI.Dhtand moves all commands toCoreAPI.Routing: we can't just remove them now because this is the public RPC API interface which was never marked as deprecated. We can remove the deprecatedDhtAPIin the next version.RoutingAPIoptions consistent with the remaining of the code.Putis now aliased toRoutingand marked as deprecated. This brings the options forRoutingAPIinline with the rest of the API.