-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core/node: prioritize announcing pin roots #10376
Conversation
926744f
to
c4ec92b
Compare
A couple options that seem reasonable:
Both of these would let you capture ordering without being that annoying (e.g. you could also run a custom DHT server node instead of using a delegated router for provides). |
6f478c3
to
85f8327
Compare
85f8327
to
d1b78da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, but we need updates to internals from ipfs/boxo#595 to avoid memory usage when providing non-roots (the remainder of datatstore).
4012ea4
to
88b05f4
Compare
36445c1
to
44d2702
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with and without accelerated client, seems to work ok.
AFAIK we don't have any announcement benchmarks we could run, but eyeballing ipfs stats provide
seems to be no slower than the old all
.
I think doing this by default is net positive, but included flat
strategy below as a precaution.
8f654b2
to
444f0e8
Compare
Adding 'flat' strategy which works the same as the old default 'all'. This way if anyone has memory-related regressions, they can fix without waiting for a new release.
444f0e8
to
9434294
Compare
This should close #10365.