feat: go-libp2p 0.36 and /webrtc-direct listener #10463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
force-pushed
the
feat/enable-webrtc-direct
branch
4 times, most recently
from
af67762
to
a8d2a7c
Compare
lidel
force-pushed
the
feat/enable-webrtc-direct
branch
2 times, most recently
from
009fb8d
to
9773255
Compare
|
(Marking as blocked until go-libp2p allows listening on the same UDP port as |
lidel
changed the title
lidel
force-pushed
the
feat/enable-webrtc-direct
branch
2 times, most recently
from
37eafa3
to
7177fe0
Compare
lidel
changed the title
lidel
force-pushed
the
feat/enable-webrtc-direct
branch
from
7177fe0
to
b3719e8
Compare
switches to version from libp2p/go-libp2p#2889
lidel
force-pushed
the
feat/enable-webrtc-direct
branch
from
b3719e8
to
f7868e6
Compare
lidel
commented
Jul 30, 2024
lidel
commented
Jul 30, 2024
go.sum
Outdated
Comment on lines
333
to
334
| github.com/ipfs/boxo v0.20.0 h1:umUl7q1v5g5AX8FPLTnZBvvagLmT+V0Tt61EigP81ec= | ||
| github.com/ipfs/boxo v0.20.0/go.mod h1:mwttn53Eibgska2DhVIj7ln3UViq7MVHRxOMb+ehSDM= |
There was a problem hiding this comment.
💭 unsure why go mode downgraded things here, likely boxo uses more modern deps than go-libp2p
There was a problem hiding this comment.
provisionally resolved in 2f78519
|
Confirmed most important things work:
I'll now work on migration to add listener to existing user's machines. |
lidel
added a commit
to ipfs/fs-repo-migrations
that referenced
this pull request
Aug 1, 2024
This was referenced Aug 1, 2024
migration will sort them anyway, so making the default order match the migration output to minimize the noise
lidel
force-pushed
the
feat/enable-webrtc-direct
branch
from
39cf60f
to
6ee6545
Compare
lidel
added a commit
to ipfs/fs-repo-migrations
that referenced
this pull request
Aug 2, 2024
* chore: init fs-repo-15-to-16 from 14-to-16 mostly copy & paste * feat: append /webrtc-direct if /quic-v1 present context: ipfs/kubo#10463 * chore: bump latest version * test: sharness last this way we see if latest migration e2e passes, before we hit any issues with legacy tooling tests, which is takes second place in priority of things
2 tasks
|
Migrations are ready (fs-repo-15-to-16 work happened in: ipfs/fs-repo-migrations#190, ipfs/distributions#1091). One go-test fails due to boxo version being lowered – this PR is waiting for final go-libp2p release (which hopefully will resolve dep conflict with boxo). |
lidel
force-pushed
the
feat/enable-webrtc-direct
branch
from
b7edd93
to
9e69bb7
Compare
lidel
changed the title
lidel
changed the title
same as retracted v0.36.0, but with fixed tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables WebRTC Direct transport and related listener by default.
updated.
/udp/4002/webrtc-directlistener by default (ipfs init)/udp/400X/webrtc-directlistener for existing users (write migration)/udpport (4001)Closes #9724
Closes #10416 as well (because go-libp2p now pulls-in gorilla/websocket v1.5.3)
Part of #10436