refactor object patch command to work more betterer #2154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jeromy <[email protected]>
|
should fix #2070, needs a test for that though |
|
💯 for great language |
License: MIT Signed-off-by: Jeromy <[email protected]>
whyrusleeping
added a commit
that referenced
this pull request
Jan 3, 2016
refactor object patch command to work more betterer
|
diff hard to read-- what changed here? |
|
data for object patch set-data and append-data was being encoded into the url, I moved it into the body as a multipart file (like all our other 'data' commands). The difficult part was breaking up object patch (which was a single command object) into multiple commands to allow us to specify that the data argument needed to be a file (and thus streamed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License: MIT
Signed-off-by: Jeromy [email protected]