Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated authors doc #2800

Merged
merged 1 commit into from
Aug 24, 2016
Merged

Updated authors doc #2800

merged 1 commit into from
Aug 24, 2016

Conversation

RichardLitt
Copy link
Member

License: MIT
Signed-off-by: Richard Littauer [email protected]

@Kubuxu
Copy link
Member

Kubuxu commented Jun 3, 2016

You have Jeremy three times on this list.

Also could you use my other email address: [email protected]

@RichardLitt
Copy link
Member Author

The list is automatically generated. Should we remove duplicates? Should we add multiple emails more clearly?

@dignifiedquire
Copy link
Member

If the tool to generate these uses git under the hood you can use a .mailmap to alias multiple emails, see https://github.com/karma-runner/karma/blob/master/.mailmap for an example

@Kubuxu
Copy link
Member

Kubuxu commented Jun 3, 2016

I think we already had tool that handled it for generating weekly reports.
It was working great.

@RichardLitt
Copy link
Member Author

@Kubuxu
Copy link
Member

Kubuxu commented Jun 3, 2016

Hmm, I thought about this one: https://github.com/ipfs/newsletter/blob/master/tools/get_commits.py

But I think yours is superior.

Simple mapping of email to alternative email would be enough to fix most cases.
(I just noticed that I am on this list 3 times).

@RichardLitt
Copy link
Member Author

Ah! Well, @eminence's tool get_commits.py is awesome, and part of mine. I need to make the javascript version of that.

I'll try and prioritize making a js commit version (been overloaded recently) to make this better.

@eminence
Copy link
Contributor

eminence commented Jun 3, 2016

Having two tools that do almost the same thing is kinda unfortunate, so moving the functionality of get_commits.py into name-your-contributors is a good goal

@RichardLitt
Copy link
Member Author

@eminence I'm on it, just hasn't been as prioritized as it should be as yours works, right now, and I've got other stuff. Will hopefully move it up!

@Kubuxu Kubuxu added the topic/meta Topic meta label Jun 13, 2016
@RichardLitt
Copy link
Member Author

For now, this is probably good to go?

@RichardLitt RichardLitt added the need/review Needs a review label Jun 17, 2016
@Kubuxu
Copy link
Member

Kubuxu commented Jun 17, 2016

Let me remove two of myself and one Juan.

@eminence
Copy link
Contributor

Alas, we have yet to figure out how to clone @Kubuxu and the rest of the team. If only we could, it would be a huge boon to productivity!

@Kubuxu Kubuxu force-pushed the feature/update-authors branch 2 times, most recently from 251918d to 92cd0f9 Compare June 22, 2016 14:26
@Kubuxu
Copy link
Member

Kubuxu commented Jun 22, 2016

LGTM

@Kubuxu Kubuxu added RFM and removed need/review Needs a review labels Jun 22, 2016
Stephan Seidt <[email protected]>
Stephan Seidt <[email protected]>
Stephen Sugden <[email protected]>
Stephen Whitmore <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still a duplicate here

@RichardLitt
Copy link
Member Author

Will make a deduplicator.

@RichardLitt RichardLitt added need/author-input Needs input from the original author and removed RFM labels Jun 22, 2016
@RichardLitt RichardLitt self-assigned this Jun 22, 2016
@RichardLitt RichardLitt force-pushed the feature/update-authors branch 2 times, most recently from f466dd1 to 36cbe9e Compare June 30, 2016 14:03
@RichardLitt
Copy link
Member Author

Just did it manually. Should be good to go.

@RichardLitt RichardLitt removed their assignment Jun 30, 2016
@RichardLitt RichardLitt added need/review Needs a review and removed need/author-input Needs input from the original author labels Jun 30, 2016
License: MIT
Signed-off-by: Richard Littauer <[email protected]>
@whyrusleeping whyrusleeping merged commit 81acd6a into master Aug 24, 2016
@whyrusleeping whyrusleeping deleted the feature/update-authors branch August 24, 2016 17:06
@ghost ghost mentioned this pull request Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/review Needs a review topic/meta Topic meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants