docs: decapitalize IPFS where possible

[RichardLitt]

Tried to check all instances of IPFS and make sure they werent referring to the CLI tool. See #2910.

License: MIT
Signed-off-by: Richard Littauer [email protected]

[Kubuxu]

In this case it should probably capital. It is about IPFS object.

[RichardLitt]

@Kubuxu updated

[Kubuxu]

SGTM but now you have merge conflict with master, you need to rebase.

[RichardLitt]

@Kubuxu rebased

[whyrusleeping]

why is this one lowercase while the surrounding two are capitalized?

[whyrusleeping]

@RichardLitt youre gonna have to fix some of the tests. You changed print statements that we test the output of

[RichardLitt]

@whyrusleeping I tried to find the failing tests that are relevant to this, and I'm not seeing any. Can you help me?

[Kubuxu]

@RichardLitt t0020 - ipfs init should not run while daemon is running and ipfs cat no repo message looks good

When you open test console on circle, search for not ok.

[RichardLitt]

@Kubuxu I saw both of those: I don't know how to fix those particular issues. What code should I change to make that pass? How would I know? Can you please help me by listing exactly what you would do to fix one of these, here - I just don't know the workflow.

[whyrusleeping]

@RichardLitt take a look at the code for the test that is failing. They are in the test/sharness folder. The string next to the 'not ok' messages tells you which test. Look at the code being executed by the test and see why it would be failling.

[RichardLitt]

Ok:

1. I looked at ipfs cat no repo message looks good
2. I saw that it is making a command, and piping it to cat_test_out.
3. I replicate that by running:

test_expect_success "ipfs cat fails" '
    export IPFS_PATH="$(pwd)/.ipfs" &&
    test_must_fail ipfs cat Qmaa4Rw81a3a1VEx4LxB7HADUAXvZFhCoRdBzsMZyZmqHD 2> cat_fail_out

as

export IPFS_PATH="$(pwd)/.ipfs" &&
ipfs cat Qmaa4Rw81a3a1VEx4LxB7HADUAXvZFhCoRdBzsMZyZmqHD

It looks fine to me, and no different on master, where I run the same thing. What am I missing?

[RichardLitt]

@whyrusleeping Can you help me with my question above?

[RichardLitt]

@Kubuxu?

[whyrusleeping]

@RichardLitt The issue here is that you changed the capitalization of ipfs. in some tests
in some tests we are expecting to see it lowercase, but now its capitalized.

You will have to update these tests and change the capitalization the same way you did in the code.

While on this branch, cd into the test/sharness folder and run make deps. Then set export TEST_NO_FUSE=1 to skip running the fuse tests (they likely won't run on your machine anyways), and export TEST_VERBOSE=1 to see verbose test output. After that, you can run make or run any of the tests individually with ./test-name.sh -v.

[RichardLitt]

Updated. Only failures were in the docker tests, which were unrelated - not sure why those aren't working.