docker: take -dev version suffix into account #2937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
kind/bug
|
This fix is pretty important because it's making master green again!!11 |
|
Could we just grep the version string with expected hash instead? This way if we choose other suffix (rc for example) it won't break again. |
|
Something like |
|
You could use {"Version":"0.4.3-dev","Commit":"4fa85cc","Repo":"4","System":"amd64/linux","Golang":"go1.6.2"}or |
ghost
force-pushed
the
feature/docker-dev-suffix
branch
from
f8eb025
to
b639005
Compare
added 2 commits
July 3, 2016 01:45
The double and single quotes got too damn complicated, so heredoc we go! License: MIT Signed-off-by: Lars Gierth <[email protected]>
License: MIT Signed-off-by: Lars Gierth <[email protected]>
ghost
force-pushed
the
feature/docker-dev-suffix
branch
from
b639005
to
afda38f
Compare
|
Updated it to parse from |
|
bashy bashy bashy bash. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other commit makes sharness tests work with my symlinked-into-gopath setup.