Update dns help with a correct domain name #3087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,7 +26,7 @@ This command resolves those links to the referenced object. | |||
|
|
|||
| For example, with this DNS TXT record: | |||
|
|
|||
| > dig +short TXT ipfs.io | |||
| > dig +short TXT _dnslink.ipfs.io | |||
There was a problem hiding this comment.
this change does not need to happen. it can be either. I'm not sure we want it to happen.
the documentation reads "with this X, then Y" it does not require a working DNS record, and it could use example.com instead.
There was a problem hiding this comment.
So you want a broken example? I don't understand?
There was a problem hiding this comment.
Working example is much better than dummy one, example.com is nice because it works, you can fetch A record of it, you can open it via HTTP, but it won't work in this case.
Closes ipfs-inactive/faq#161 License: MIT Signed-off-by: Kevin Simper <[email protected]>
|
I think this is fine. LGTM |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ipfs-inactive/faq#161