-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ds-help: add helper functions to convert from Cid to DsKey and the reverse #3310
Conversation
2b09019
to
cf9e12d
Compare
Maybe these should be in the dshelper package? |
I take it you mean |
@kevina the thing is that your helper methods would be useful in nearly every place that that package is used. |
No problem, I'll move it. |
License: MIT Signed-off-by: Kevin Atkinson <[email protected]>
cf9e12d
to
c4fbe34
Compare
@whyrusleeping, moved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@whyrusleeping tests passed. Marking a RFM. |
In the filestore (#2634) i needed to convert from Cid to DsKey and the reverse in several places so I created two helper functions to that effect.