Use NextSync method in Datastore #3386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevina
changed the title
whyrusleeping
added
status/ready
kevina
force-pushed
the
kevina/nextsync
branch
from
4970133
to
844b425
Compare
kevina
removed
the
status/blocked
| @@ -186,8 +186,9 @@ func (bs *blockstore) AllKeysChan(ctx context.Context) (<-chan *cid.Cid, error) | |||
| select { | |||
| case <-ctx.Done(): | |||
There was a problem hiding this comment.
since we're checking the context at the send layer (and this is in a goroutine, and not expected to really block) we can do away with the select and context check entirely here.
There was a problem hiding this comment.
so just use something like:
e, ok := res.NextSync()
if !ok { return nil, false }
...
Note: Edited.
There was a problem hiding this comment.
No need for a for loop there either i think
License: MIT Signed-off-by: Kevin Atkinson <[email protected]>
kevina
force-pushed
the
kevina/nextsync
branch
from
844b425
to
24aa42d
Compare
License: MIT Signed-off-by: Kevin Atkinson <[email protected]>
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ipfs/go-datastore#53 ipfs/go-datastore#54