Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistent ipfs stats bw formatting #3554

Merged
merged 1 commit into from
Jan 1, 2017
Merged

Fix inconsistent ipfs stats bw formatting #3554

merged 1 commit into from
Jan 1, 2017

Conversation

mateon1
Copy link
Contributor

@mateon1 mateon1 commented Jan 1, 2017

The current way the command formats its output is inconsistent, sometimes the output is shorter and sometimes it's longer, which causes issues when using ipfs stats bw --poll
This PR makes the output always the same length.

Example of how it looks:

mateon1@deimos:~$ ipfs stats bw --poll -i 200ms
Total Up    Total Down  Rate Up     Rate Down
  2.1 GB      3.6 GB      3.4 kB/s    4.2 kB/s

@mateon1
Fix inconsistent ipfs stat bw formatting
e1e57c8 
License: MIT
Signed-off-by: Mateusz Naściszewski <[email protected]>
whyrusleeping
whyrusleeping approved these changes Jan 1, 2017
View reviewed changes
Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this was bothering me the other day too. Thanks!

@whyrusleeping whyrusleeping merged commit defd1a1 into ipfs:master Jan 1, 2017
@mateon1 mateon1 deleted the fix/inconsistent-bw branch January 1, 2017 19:21
@ghost ghost mentioned this pull request Jan 27, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyrusleeping whyrusleeping whyrusleeping approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mateon1 @whyrusleeping