Fix "ipfs ls" to once again work on arbitrary dag objects. #4184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevina
force-pushed
the
kevina/fix-4075
branch
2 times, most recently
from
b09e100
to
d90a07f
Compare
kevina
changed the title
License: MIT Signed-off-by: Kevin Atkinson <[email protected]>
License: MIT Signed-off-by: Kevin Atkinson <[email protected]>
kevina
force-pushed
the
kevina/fix-4075
branch
from
d90a07f
to
2fbb451
Compare
|
Should this really be listing the links at the merkledag level? |
|
This simply restores the old behavior (before c4c6653) instead of returning the error. |
|
you're right... we can fix that later (#4186) |
|
@Kubuxu @victorbjelkholm why does the jenkins link take me to a broken ngrok? |
|
@victorbjelkholm was updating the jenkins. Something broke? |
I was running tests from local jenkins instance to verify that new changes were not breaking stuff. I rerun the job on the production instance now, and the link have changed to https://ci.ipfs.team/blue/organizations/jenkins/go-ipfs/detail/PR-4184/ now Sorry for that! |
whyrusleeping
approved these changes
Aug 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4075
License: MIT
Signed-off-by: Kevin Atkinson [email protected]