[WIP] Next round of extractions (blockservice, merkledag, path)

[dignifiedquire]

This PR extracts the following packages

• ./blockservice -> ipfs/go-ipfs-blockservice
• ./merkledag - > ipfs/go-ipfs-merkledag
• ./path -> ipfs/go-ipfs-path
• ./path/resolver -> ipfs/go-ipfs-path-resolver
• ./thirdparty/verifcid -> ipfs/go-verifcid

I tried to extract less at once, but these are all depended on each other in some form, so ripping them out at once was the easiest way I could see

I have the individual packages ready to push, please let me know if I can go ahead and create the repos with their respective PRs.

Edit Yes gitcop, I will make you happy next time I push...

[kevina]

Note, thirdparty/verifcid is a temporary package that will likely go away once ipfs/go-cid#40 lands so it should not be extracted.

Also, is there a strong need for this right now?

[magik6k]

#4672 and following PRs will refactor path, path/resolver and also touch merkledag. path package will likely get merged into CoreAPI, so this is going to make these refactors move slower.

cc @Stebalien

[magik6k]

Looks like there are some missing changes to package.json

[dignifiedquire]

yeah no new imports done yet as things havent been published to gx yet

…

On 21. Apr 2018, 23:26 +0200, Łukasz Magiera ***@***.***>, wrote: @magik6k commented on this pull request. Looks like there are some missing changes to package.json — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.

[hsanjuan]

So happy to see this.

@ZenGround0 keep an eye on this, as this should allow to fully remove the go-ipfs dep from cluster/sharding.

@dignifiedquire I think you missed unixfs extraction?

[hsanjuan]

@dignifiedquire the process I've been following is:

• Create new repos
• Import history from go-ipfs
• Add Readmes, license, makefiles, travis, gx
• Publish gx
• Then make the PR to go-ipfs

[dignifiedquire]

@hsanjuan yeah I have done all of that, except for the push to github and publish part, as I wanted feedback on the new repo names & granularity first.

Re unixfs, it wasn't necessary to make this round of extraction work, so I was leaving that for another round

[dignifiedquire]

I have created and pushed the code for the packages to

• https://github.com/ipfs/go-ipfs-blockservice
• https://github.com/ipfs/go-ipfs-merkledag
• https://github.com/ipfs/go-ipfs-path
• https://github.com/ipfs/go-ipfs-path-resolver

Any thoughts what to do about verifcid? How long is the proper fix expected to take until it is propagated up?

[hsanjuan]

Re unixfs, it wasn't necessary to make this round of extraction work, so I was leaving that for another round

Ah yes, you're right. For the next one :)

[hsanjuan]

Bumping this. The problem with not merging extractions rapidly is that it becomes very time consuming to maintain the new repos in sync.

I would extract verify-cid temporally as a way to unblock everyone depending on this..

[dignifiedquire]

closing, as this work was done in other places