gateway: fix further resolution of dnslink failures #5199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A while ago, we noticed that if IpnsHostname failed to look up a dnslink for a hostname in a Host header, it wouldn't respond with an error, but instead just skip the Host header part and carry on. In the issue were this was flagged, the example was: `_dnslink.tr.wikipedia-on-ipfs.org => /ipns/QmSomeKey` This key had stopped to resolve, and thus the resolution of /ipns/tr.wikipedia-on-ipfs.org would fail. Now you'd expect an error response, but instead it'd happily continue processing the request, disregarding the Host header, and allowing requests to e.g. http://tr.wikipedia-on-ipfs.org/ipns/libp2p.io to succeed. A previous patch (#4977) tried to work around this issue by limiting the recursion depth of Host: header dnslink resolutions to 1. In this patch we start to correctly handle the initial resolution error and stop processing the request, and we remove the earlier workaround. License: MIT Signed-off-by: Lars Gierth <[email protected]>
ghost
added
kind/bug
ghost
requested a review
from
ghost
self-assigned this
|
This isn't correct yet -- we'll want to still carry on with the request if we "successfully" get a NXDOMAIN response from DNS. |
Stebalien
added a commit
that referenced
this pull request
Jul 7, 2018
Namesys returns `ErrResolveRecursion` when it stops recursing due to a depth limit. It doesn't return success. Alternative to #5199. License: MIT Signed-off-by: Steven Allen <[email protected]>
|
Replaced by #5202 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago, we noticed that if IpnsHostname failed to look up
a dnslink for a hostname in a Host header, it wouldn't respond
with an error, but instead just skip the Host header part and
carry on.
In the issue were this was flagged, the example was:
_dnslink.tr.wikipedia-on-ipfs.org => /ipns/QmSomeKeyThis key had stopped to resolve, and thus the resolution of
/ipns/tr.wikipedia-on-ipfs.org would fail. Now you'd expect
an error response, but instead it'd happily continue processing
the request, disregarding the Host header, and allowing requests
to e.g. http://tr.wikipedia-on-ipfs.org/ipns/libp2p.io to succeed.
A previous patch (#4977) tried to work around this
issue by limiting the recursion depth of Host: header dnslink
resolutions to 1.
In this patch we start to correctly handle the initial resolution
error and stop processing the request, and we remove the earlier
workaround.
License: MIT
Signed-off-by: Lars Gierth [email protected]