fix ipfs help bug #5557
#5573
Merged
fix ipfs help bug #5557
#5573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djdv
suggested changes
Oct 9, 2018
|
My review is squashed. |
Kubuxu
reviewed
Oct 9, 2018
cmd/ipfs/main.go
Outdated
| if os.Args[1] == "help" { | ||
| if len(os.Args) > 2 { | ||
| os.Args = append(os.Args[:1], os.Args[2:]...) | ||
| os.Args = append(os.Args, "-h") |
There was a problem hiding this comment.
I would switch it to --help as -h is a short help and --help is a long help. (help help help :smile)
|
@djdv @Kubuxu @Stebalien i have update the pr . And I have changed |
Kubuxu
reviewed
Oct 29, 2018
License: MIT Signed-off-by: Kejie Zhang <[email protected]>
License: MIT Signed-off-by: Kejie Zhang <[email protected]>
|
Thx for advice @Kubuxu.I have update my pr.Please help me review it again. |
Stebalien
approved these changes
Nov 6, 2018
|
This is a bit funky but, well, it was already kind of a hack. This should at least be less surprising for users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #5557
License: MIT
Signed-off-by: Kejie Zhang [email protected]