race fixes #566
Merged
race fixes #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the datastores used by pinners and so on should be mutex wrapped. One issue with changing all of them from ds.Datastore -> ds.ThreadSafeDatastore is that we wrap the incoming ds.ThreadSafeDatastore with other datastores, which do not implement the interface. Re-wrapping again causes double locking. (which may be ok..., but...) any ideas?
|
Fails race detector for unrelated reason LGTM RFM |
|
@briantigerchow i was thinking we can dump a lot of the fixes here over the next day or so. do you prefer to merge right away? (i guess higher SNR). We can also keep this PR open and merge manually into master. |
Would be nice to get Jenkins to quiet down. Personally, I'm happy to deal with the bit of extra work if it means we can get tests green again. I'm also okay tacking these sorts of fixes onto bigger PRs alternatively. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to get rid of all the nasty race problems.
Now we have tests running all the time for 'em, it'll
be way easier to do it incrementally (thanks @briantigerchow!)
Let's get this party started: