coreapi: add some seeker tests #5934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
added
kind/test
ghost
assigned
magik6k
force-pushed
the
tests/coreapi-seek
branch
from
d0892cd
to
149c31d
Compare
This was referenced Jan 21, 2019
magik6k
force-pushed
the
tests/coreapi-seek
branch
2 times, most recently
from
f7ac914
to
42050a0
Compare
Stebalien
removed
the
status/blocked
Stebalien
force-pushed
the
tests/coreapi-seek
branch
from
42050a0
to
987095e
Compare
|
Something still appears broken here. |
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
magik6k
force-pushed
the
tests/coreapi-seek
branch
from
987095e
to
3f4311b
Compare
|
Test incorrectly handled |
Stebalien
approved these changes
Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests dagreader in
go-unixfs/io, and it turns out it's currently broken in 2 ways:When seeking near end of the file and the reading into buffer larger than the file,(this is valid behaviour, just not consistent across readers)Readseems to read the data, but incorrectly returns io.EOFWhen seeking with
io.SeekEnd, DagReader incorrectly inverts the offset.