test: ipfs add with CIDv1 as default #8185
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is only for demonstration purposes, to identify all tests that require refactor and eventually close #4143 and ipfs/specs#247
Motivation
Main use case for CIDv1 is
ipfs://
URI and subdomain gateways. In both cases we want case-insensitive base32 to avoid issues like ipfs/ipfs-companion#1006.MVP: default unixfsv1 to CIDv1
Virtually all DAGs used in mentioned contexts are unixfsv1, so we can effectively solve most of issues by ensuring unixfsv1 imports produce CIDv1:
ipfs add
- hereipfs files mkdir|write
- feat(unixfs): use cidv1 by default #8886ipfs object new|put|patch
(for completeness, otherwise we will see people producing CIDv0) - feat(cmds/object): use CIDv1 by default #8896Alternative is to switch the defaults in github.com/ipfs/go-ipfs-files
Identified tests to fix