Ensure that folder exists before moving ipfs binary. #8934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
guseggert
reviewed
May 5, 2022
cmd/ipfs/dist/install.sh
Outdated
| @@ -15,6 +15,7 @@ is_write_perm_missing="" | |||
| for raw in $binpaths; do | |||
| # Expand the $HOME variable. | |||
| binpath=$(eval echo "$raw") | |||
| mkdir -p $binpath | |||
There was a problem hiding this comment.
Suggested change
| mkdir -p $binpath | |
| mkdir -p "$binpath" |
(need to quote in case there's a space in the path)
There was a problem hiding this comment.
Suggested change
| mkdir -p $binpath | |
| mkdir -p ${binpath} |
Use ${} syntax in case there is a space and a quote in the path.
There was a problem hiding this comment.
The expansion needs to be quoted to protect against spaces, even when using curly braces. In this case, the curly braces are equivalent and just a style preference. So it needs to be either "$binpath" or "${binpath}" (I don't really care which), but not $binpath nor ${binpath}.
ajnavarro
force-pushed
the
fix/install-on-mac-m1-monterey
branch
from
9b29d70
to
09d7c13
Compare
On macOS Monterey there is no /usr/local/bin folder and we need to create it.
ajnavarro
force-pushed
the
fix/install-on-mac-m1-monterey
branch
from
09d7c13
to
7e488c1
Compare
guseggert
pushed a commit
that referenced
this pull request
Jun 8, 2022
guseggert
pushed a commit
that referenced
this pull request
Jun 8, 2022
(cherry picked from commit ae15e18)
guseggert
pushed a commit
that referenced
this pull request
Jun 8, 2022
(cherry picked from commit ae15e18)
guseggert
pushed a commit
that referenced
this pull request
Jun 8, 2022
(cherry picked from commit ae15e18)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS Monterey there is no
/usr/local/binfolder and we need to create it.Closes #8347.