fix: remove mdns_legacy #9048
Merged
fix: remove mdns_legacy #9048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've been running both implementations for a long, long time. It is time to remove legacy version and lower the number of LAN packets IPFS node produces.
lidel
force-pushed
the
fix/remove-legacy-mdns
branch
from
797f60e
to
d3bcfa3
Compare
marten-seemann
approved these changes
Jun 19, 2022
core/node/libp2p/discovery.go
Outdated
| @@ -49,12 +48,6 @@ func SetupDiscovery(useMdns bool, mdnsInterval int) func(helpers.MetricsCtx, fx. | |||
| if mdnsInterval == 0 { | |||
There was a problem hiding this comment.
You can remove this as well.
There was a problem hiding this comment.
@marten-seemann we have the implicit default documented here – is it the same in libp2p?
There was a problem hiding this comment.
This is not configurable any more in the new mDNS implementation.
|
quick cc:
|
yes, I believe that's all rust-libp2p implements at this point |
|
Removed Replaced Ready for final review / merge – my hope is to ship this in 0.14. |
marten-seemann
approved these changes
Jun 26, 2022
3 tasks
hannahhoward
pushed a commit
to filecoin-project/kubo-api-client
that referenced
this pull request
Jun 19, 2023
* fix: remove mdns_legacy We've been running both implementations for a long, long time. It is time to remove legacy version and lower the number of LAN packets IPFS node produces. See ipfs/kubo#9048 (comment) for the Interval removal rational.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the ancient
mdns_legacyimplementation.@marten-seemann @schomatis thoughts on removing old one? any concerns?