Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin: follow async pinner changes, use directly CoreApi.Pin.Verify #9692

Closed
wants to merge 1 commit into from

Conversation

MichaelMure
Copy link
Contributor

@MichaelMure MichaelMure commented Mar 3, 2023

This PR follow the changes in the Pinner to make listing recursive and direct pins asynchronous, which in turns allow pin/ls to build and emit results without having to wait anything, or accumulate too much in memory.

Note: there is a tradeoff for pin/ls?type=all:

  • keep the recursive pins in memory (which I chose)
  • ask the pinner twice for the recursive pins, and limit memory usage

Additionally, I improved CoreApi.Pin.Verify so that it can be used in the pin/verify command, instead or re-implementing everything.

Depends on:

@MichaelMure MichaelMure force-pushed the streamed-pins branch 3 times, most recently from 385e2aa to 6d5a036 Compare March 3, 2023 15:55
@MichaelMure MichaelMure marked this pull request as ready for review March 3, 2023 16:08
@aschmahmann aschmahmann requested a review from Jorropo March 6, 2023 14:23
@guseggert guseggert added P2 Medium: Good to have, but can wait until someone steps up need/maintainer-input Needs input from the current maintainer(s) labels Apr 3, 2023
@BigLep BigLep mentioned this pull request Apr 5, 2023
@BigLep BigLep mentioned this pull request Apr 19, 2023
@MichaelMure MichaelMure closed this May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/maintainer-input Needs input from the current maintainer(s) P2 Medium: Good to have, but can wait until someone steps up
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants