Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: port routing DHT tests to Go #9709

Merged
merged 1 commit into from
Mar 29, 2023
Merged

test: port routing DHT tests to Go #9709

merged 1 commit into from
Mar 29, 2023

Conversation

guseggert
Copy link
Contributor

@guseggert guseggert commented Mar 9, 2023

This is a followup from #9708

@guseggert guseggert force-pushed the test/port-routing-dht branch 3 times, most recently from 6e6824d to 09b5d6d Compare March 16, 2023 11:39
@guseggert guseggert requested a review from lidel March 16, 2023 12:25
@guseggert guseggert marked this pull request as ready for review March 16, 2023 12:26
@guseggert guseggert self-assigned this Mar 16, 2023
@BigLep BigLep requested a review from Jorropo March 19, 2023 15:10
Copy link
Contributor

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, feel free to merge if you correct or answer the three comments.

test/cli/routing_dht_test.go Outdated Show resolved Hide resolved
test/sharness/t0170-routing-dht.sh Show resolved Hide resolved
test/sharness/t0170-routing-dht.sh Show resolved Hide resolved
@guseggert guseggert requested a review from Jorropo March 29, 2023 21:13
@guseggert guseggert merged commit 9fb09dd into master Mar 29, 2023
@guseggert guseggert deleted the test/port-routing-dht branch March 29, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants