Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Release: v0.19.0 #9741

Merged
merged 28 commits into from
Mar 20, 2023
Merged

Merge Release: v0.19.0 #9741

merged 28 commits into from
Mar 20, 2023

Conversation

galargh
Copy link
Contributor

@galargh galargh commented Mar 20, 2023

This PR merges the release branch v0.19.0 to master

galargh and others added 27 commits March 6, 2023 12:30
By default, `go install` will install go $GOBIN and not $GOPATH/bin. In
most cases there is no functional difference -- `go install` falls
back to $GOPATH/bin when $GOBIN is empty.
ci: remove disabled testground workflow
docs: add bifrost to early testers
This does nothing, just move from an untagged commit to a tagged commit but contain the same things.
This routing type is the same as "auto" but it creates the DHT in
"client" mode and hence does not start a DHT server.
This commit replaces `os.MkdirTemp` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.

Prior to this commit, temporary directory created using `os.MkdirTemp`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
	defer func() {
		if err := os.RemoveAll(dir); err != nil {
			t.Fatal(err)
		}
	}
is also tedious, but `t.TempDir` handles this for us nicely.

Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <[email protected]>
This is the slowest test in the sharness test suite, because it has
very long sleeps. It usually takes 2+ minutes to run.

This new impl runs all peering tests in about 20 seconds, since it
polls for conditions instead of sleeping, and runs the tests in
parallel.

This also has an additional test case for a peer that was never online
and then connects.
@galargh galargh requested a review from lidel as a code owner March 20, 2023 15:44
@galargh galargh requested a review from hacdias March 20, 2023 16:20
@galargh galargh merged commit 77a64f0 into master Mar 20, 2023
gammazero pushed a commit to ipfs/boxo that referenced this pull request Sep 28, 2023
Merge Release: v0.19.0

This commit was moved from ipfs/kubo@77a64f0
gammazero pushed a commit to ipfs/boxo that referenced this pull request Sep 29, 2023
Merge Release: v0.19.0

This commit was moved from ipfs/kubo@77a64f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants