fix(ci): speed up docker build #9800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trying two things: - speed up arm build by allowing cross-comp from go instead of slow QEMU - take a stab at caching buildx layers, without infinite growth This fix was laready applied in ipfs-inactive/bifrost-gateway@14cfa48 and reduced build time from 20m to 3m.
lidel
force-pushed
the
fix/docker-image-build-time
branch
from
f331979
to
790a548
Compare
|
Wow, after merging this PR docker build time decreased from ~50-40m to ~6m 🤯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building docker images in this repo takes ~1h:
This PR is doing two things (iiuc -- please verify my assumptions 🙏 ):
docker buildx buildand the regulardocker buildThis fix was already applied in ipfs-inactive/bifrost-gateway@14cfa48 and seems to reduce docker build times there from 20m to 3m ❣️ :
cc @galargh @laurentsenta @guseggert