Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: adhere more closely to the language guide for proto3 default values #66

Merged
merged 4 commits into from
Oct 12, 2022
Merged

fix!: adhere more closely to the language guide for proto3 default values #66

merged 4 commits into from
Oct 12, 2022

Commits on Oct 8, 2022

  1. fix: adhere more closely to the language guide for proto3 default values 

    Only write singular fields when they are non-default values (unless in
repeated fields).  Always write optional values even when they are non-default
values.

Updates test suite to compare generated bytes to protobuf.js to ensure compatibility.

Also adds a README section on differences between protons and protobuf.js

fixes #43
    @achingbrain
    achingbrain committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    f67bc1b View commit details
    Browse the repository at this point in the history

  2. chore: check protobuf.js can decode protons output

    @achingbrain
    achingbrain committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    ae21ad2 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. fix: compare to protobuf.js defaults

    @achingbrain
    achingbrain committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    9f01287 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. fix: fix up singular message types

    @achingbrain
    achingbrain committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    c0fabc4 View commit details
    Browse the repository at this point in the history