-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Merkle links key from mlink to link #64
Rename Merkle links key from mlink to link #64
Conversation
this LGTM. though do we want |
I didn't understand what you said about |
Sorry, let me rephrase: do we want (i myself am leaning towards directives + escaping) |
If you want to add escaping, we can either let the application do the escaping on their own, or handle the escaping ourselves. Escaping implies that we will be able to provide the application with either the escaped (original) version, or the unescaped (with link information removed) objects. If the application wants to look at links, it will not be able to do so in the unescaped version the I'd be tempted to say it doesn't matter if the application create links unknowingly. We'll just never use them. So let's use If we want to provide an easy way to avoid that, just use |
Very well thought out. thanks
Yep totally agreed here, i think this ^ is the right choice. |
Rename Merkle links key from mlink to link
thanks @mildred |
Merges to #37
Replaces
mlink
occurrences withlink
with a paragraph to explain how merkle-links are formed. Original comment and follow up