Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

fix: lock stable dep #66

Merged
merged 1 commit into from
Apr 16, 2018
Merged

fix: lock stable dep #66

merged 1 commit into from
Apr 16, 2018

Conversation

fsdiogo
Copy link
Contributor

@fsdiogo fsdiogo commented Apr 16, 2018

This PR locks the stable dependecy to a working version, as the latest one breaks all the browser tests.

Fixes #65.

Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please put the information on why this change was done into the commit message? You can just copy the text from the pull request message. This way people can check why it is pinned without using GitHub.

This PR locks the stable dependecy to a working version, as the latest one breaks all the browser tests.

Fixes ipld#65.
@fsdiogo
Copy link
Contributor Author

fsdiogo commented Apr 16, 2018

Done!

@vmx
Copy link
Member

vmx commented Apr 16, 2018

The CI did already pass, only the commit message changed. Hence I dare to merge it.

@vmx vmx merged commit 4174338 into ipld:master Apr 16, 2018
@MattiasBuelens
Copy link

stable version 0.1.8 has been released which contains a fix for Two-Screen/stable#9. You should be able to unlock the dependency again.

Once again, sorry for the inconvenience!

@fsdiogo
Copy link
Contributor Author

fsdiogo commented Apr 26, 2018

Cool! Thanks @MattiasBuelens!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants