Merging Px envelopes branch #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should get back later for whole phase diagrams
New module to realize the calculation of Px envelopes via the continuation method. Right now works with 2phase lines, with a starting point of three phase lines calculation.
Added a new namelist to input files.
Now the EoS come from an external library, yaeos. The calls are still direct to the legacy code, so an enventual fix should occur. But first an IO must be defined on the yaeos side, to include any kind of model from an input file.
Now the main program gets part of it's settings from the cli library `flap`
Added the calculation of three-phase Px lines. For now it's a beta-stage, where only a three-phase region is calculated based on finding an intersection. This verifies that the three-phase lines model works properly, and later on more ways of initialization will be implemented.
Modified the tolerances to assure the same intersection is not repeated. This probably should be revisited with more tests later.
This should be part of the `yaeos` set later
Don't write if passed max of iterations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big change, with a big architectural and general intent change. Now this project aims to be a fully functional program to calculate and show phase diagrams of multicomponent mixtures. Including both PT and Px diagrams with two and three phase regions