Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to pathlib and cache groups for better end-user experience #23

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

fedebenelli
Copy link
Member

Main modifications:

  • Now the paths for to_clapeyron work using the logic of Python's pathlib, which is a more portable way of defining paths to directories and files.
  • The instantiate_mol_object can now be cached to have a better experience working with notebooks

The use of `pathlib` gives a more portable usage of paths to directories
and files in comparison to just using plain strings.
Copy link
Member

@SalvadorBrandolin SalvadorBrandolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excelent, thank you. The pathlib use must be applied also in the module "models" (by me, just a reminder)

@SalvadorBrandolin SalvadorBrandolin merged commit 0686e89 into ipqa-research:main Apr 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants