-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add out-of-band node metrics #299
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #299 +/- ##
==========================================
- Coverage 72.87% 72.81% -0.06%
==========================================
Files 67 70 +3
Lines 6706 6935 +229
==========================================
+ Hits 4887 5050 +163
- Misses 1819 1885 +66
|
zeeshanlakhani
added
observability
Anything related to metrics, tracing, etc
and removed
enhancement
New feature or request
labels
Sep 11, 2023
Updated #184 to capture this as one of the 3 main tiers of metrics. |
bgins
force-pushed
the
bgins/add-oob-node-metrics
branch
2 times, most recently
from
September 12, 2023 03:16
d44c437
to
e08068b
Compare
bgins
force-pushed
the
bgins/add-oob-node-metrics
branch
2 times, most recently
from
September 13, 2023 16:18
3e381d1
to
06cbe2e
Compare
bgins
force-pushed
the
bgins/add-oob-node-metrics
branch
2 times, most recently
from
September 13, 2023 22:08
60518b0
to
93cc6a7
Compare
bgins
force-pushed
the
bgins/add-oob-node-metrics
branch
from
September 13, 2023 22:16
93cc6a7
to
c1f1545
Compare
zeeshanlakhani
approved these changes
Sep 13, 2023
@bgins few minor things, but this is looking great. |
great work @bgins |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the following features:
serial
tofile_serial
in integration teststaplo
to pre-commit config and nix flakeLink to issue
Implements #184
Type of change
Test plan (required)
We have an integration test in
homestar-runtime/tests/metrics.rs
.