Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add out-of-band node metrics #299

Merged
merged 10 commits into from
Sep 14, 2023
Merged

feat: Add out-of-band node metrics #299

merged 10 commits into from
Sep 14, 2023

Conversation

bgins
Copy link
Contributor

@bgins bgins commented Sep 7, 2023

Description

This PR adds the following features:

  • Add system metrics
  • Add process metrics
  • Add network metrics
  • Add load average metric
  • Add database size metric
  • Add OS and kernel log entry
  • Add Prometheus exporter with endpoint for scraping
  • Move integration test utils into a separate module
  • Break Homestar process kills into *nix and windows functions
  • Switch from serial to file_serial in integration tests
  • Add taplo to pre-commit config and nix flake

Link to issue

Implements #184

Type of change

  • New feature (non-breaking change that adds functionality)
  • Refactor

Test plan (required)

We have an integration test in homestar-runtime/tests/metrics.rs.

@bgins bgins added the enhancement New feature or request label Sep 7, 2023
@bgins bgins self-assigned this Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #299 (7a023c2) into main (93a11c4) will decrease coverage by 0.06%.
The diff coverage is 74.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
- Coverage   72.87%   72.81%   -0.06%     
==========================================
  Files          67       70       +3     
  Lines        6706     6935     +229     
==========================================
+ Hits         4887     5050     +163     
- Misses       1819     1885      +66     
Files Changed Coverage Δ
homestar-runtime/src/db.rs 76.30% <ø> (ø)
homestar-runtime/src/metrics/node.rs 69.58% <69.58%> (ø)
homestar-runtime/src/metrics.rs 100.00% <100.00%> (ø)
homestar-runtime/src/metrics/exporter.rs 100.00% <100.00%> (ø)
homestar-runtime/src/runner.rs 70.87% <100.00%> (+0.18%) ⬆️
homestar-runtime/src/settings.rs 96.38% <100.00%> (+0.02%) ⬆️

... and 3 files with indirect coverage changes

@bgins bgins changed the title Add out-of-band node metrics feat: Add out-of-band node metrics Sep 8, 2023
@zeeshanlakhani zeeshanlakhani added observability Anything related to metrics, tracing, etc and removed enhancement New feature or request labels Sep 11, 2023
@zeeshanlakhani
Copy link
Contributor

Updated #184 to capture this as one of the 3 main tiers of metrics.

@bgins bgins force-pushed the bgins/add-oob-node-metrics branch 2 times, most recently from d44c437 to e08068b Compare September 12, 2023 03:16
@bgins bgins force-pushed the bgins/add-oob-node-metrics branch 2 times, most recently from 3e381d1 to 06cbe2e Compare September 13, 2023 16:18
@bgins bgins force-pushed the bgins/add-oob-node-metrics branch 2 times, most recently from 60518b0 to 93cc6a7 Compare September 13, 2023 22:08
@bgins bgins marked this pull request as ready for review September 13, 2023 22:21
@bgins bgins requested a review from a team as a code owner September 13, 2023 22:21
homestar-runtime/src/metrics.rs Show resolved Hide resolved
homestar-runtime/src/metrics/exporter.rs Show resolved Hide resolved
homestar-runtime/src/settings.rs Outdated Show resolved Hide resolved
@zeeshanlakhani
Copy link
Contributor

@bgins few minor things, but this is looking great.

@zeeshanlakhani
Copy link
Contributor

great work @bgins

@bgins bgins merged commit 1fad8c4 into main Sep 14, 2023
22 checks passed
@bgins bgins deleted the bgins/add-oob-node-metrics branch September 14, 2023 00:35
@release-plz-ipvm-wg release-plz-ipvm-wg bot mentioned this pull request Oct 9, 2023
This was referenced Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
observability Anything related to metrics, tracing, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants