Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add mDNS and Rendezvous configs #377

Merged
merged 3 commits into from
Oct 12, 2023
Merged

feat: Add mDNS and Rendezvous configs #377

merged 3 commits into from
Oct 12, 2023

Conversation

bgins
Copy link
Contributor

@bgins bgins commented Oct 11, 2023

Description

This PR implements the following features:

  • Add enable_mdns config
  • Add enable_rendezvous config

These configs determine whether we toggle mDNS and Rendezvous on or off. In addition, we check the toggle states in event handlers where we might use mDNS or Rendezvous.

Link to issue

Closes #376

Type of change

  • New feature (non-breaking change that adds functionality)
  • Refactor (non-breaking change that updates existing functionality)

Test plan (required)

All existing tests should pass. In particular, we are interested in the multi-node tests that rely on known peers and mDNS.

@bgins bgins added enhancement New feature or request networking Features, functionality involving networking labels Oct 11, 2023
@bgins bgins self-assigned this Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #377 (b9d0e25) into main (b0bda83) will decrease coverage by 0.11%.
Report is 2 commits behind head on main.
The diff coverage is 29.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
- Coverage   72.24%   72.14%   -0.11%     
==========================================
  Files          69       69              
  Lines        6872     6889      +17     
==========================================
+ Hits         4965     4970       +5     
- Misses       1907     1919      +12     
Files Coverage Δ
homestar-runtime/src/settings.rs 98.22% <100.00%> (+0.02%) ⬆️
homestar-runtime/src/network/swarm.rs 58.22% <83.33%> (-0.33%) ⬇️
homestar-runtime/src/event_handler/swarm_event.rs 16.52% <0.00%> (-0.33%) ⬇️

@bgins bgins marked this pull request as ready for review October 11, 2023 22:44
@bgins bgins requested a review from a team as a code owner October 11, 2023 22:44
@bgins bgins merged commit ea11c27 into main Oct 12, 2023
27 checks passed
@bgins bgins deleted the bgins/add-libp2p-configs branch October 12, 2023 20:23
This was referenced Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request networking Features, functionality involving networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add enable mDNS and Rendezvous config settings
3 participants