Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add CLI workflow run receipts table #490

Merged
merged 6 commits into from
Jan 4, 2024
Merged

Conversation

bgins
Copy link
Contributor

@bgins bgins commented Jan 2, 2024

Description

This PR implements the following features:

  • Add receipt table to the output of homestar run

The receipt table lists replayed receipt CIDs and associated instruction and invocation ran CIDs from a workflow run.

Type of change

  • New feature (non-breaking change that adds functionality)

Test plan (required)

Run a workflow. The new table should be empty on first run. Replayed receipt, instruction, and invocation ran CIDs should be displayed on subsequent runs.

Screenshots/Screencaps

With replayed receipts:

CleanShot 2024-01-04 at 09 25 47@2x

When no replayed receipts were available:

CleanShot 2024-01-04 at 09 26 09@2x

@bgins bgins added the dx Developer experience applications and improvements label Jan 2, 2024
@bgins bgins requested a review from a team as a code owner January 2, 2024 23:58
@bgins bgins self-assigned this Jan 2, 2024
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 52 lines in your changes are missing coverage. Please review.

Comparison is base (51f8159) 70.36% compared to head (d7bc5c7) 69.86%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #490      +/-   ##
==========================================
- Coverage   70.36%   69.86%   -0.51%     
==========================================
  Files          80       80              
  Lines        9063     9128      +65     
==========================================
  Hits         6377     6377              
- Misses       2686     2751      +65     
Files Coverage Δ
homestar-runtime/src/runner/response.rs 61.03% <65.38%> (+2.54%) ⬆️
homestar-runtime/src/runner.rs 61.88% <0.00%> (-4.60%) ⬇️

... and 2 files with indirect coverage changes

@zeeshanlakhani
Copy link
Contributor

@bgins off the top, being that this shows receipts, maybe like Receipts/Tasks Computed?

@bgins
Copy link
Contributor Author

bgins commented Jan 3, 2024

@bgins off the top, being that this shows receipts, maybe like Receipts/Tasks Computed?

Yeah, good idea! Updated it to "Receipts Computed".

Copy link
Contributor

@zeeshanlakhani zeeshanlakhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor add ask, otherwise 👍🏽

homestar-runtime/src/runner/response.rs Outdated Show resolved Hide resolved
homestar-runtime/src/runner.rs Outdated Show resolved Hide resolved
homestar-runtime/src/runner/response.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@zeeshanlakhani zeeshanlakhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor naming, otherwise, looks good. I updated #489 to mention more of what we will need from the query command.

homestar-runtime/src/runner.rs Show resolved Hide resolved
homestar-runtime/src/runner/response.rs Outdated Show resolved Hide resolved
@bgins bgins changed the title feat: Add workflow run progress table feat: Add workflow run receipts table Jan 4, 2024
@bgins bgins changed the title feat: Add workflow run receipts table feat: Add CLI workflow run receipts table Jan 4, 2024
@bgins bgins merged commit b1cf4da into main Jan 4, 2024
27 checks passed
@bgins bgins deleted the bgins/add-progress-table branch January 4, 2024 17:54
This was referenced Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Developer experience applications and improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants