Skip to content

Commit

Permalink
Fix failing test and update matrix (#1010)
Browse files Browse the repository at this point in the history
  • Loading branch information
blink1073 authored Oct 25, 2022
1 parent 03973be commit 9970618
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
9 changes: 6 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,18 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
python-version: ["3.7", "3.10"]
python-version: ["3.7", "3.11"]
exclude:
- os: macos-latest
python-version: "3.11" # not yet available
include:
- os: windows-latest
python-version: "3.9"
- os: ubuntu-latest
python-version: "pypy-3.7"
- os: ubuntu-latest
python-version: "3.11-dev"
- os: macos-latest
python-version: "3.10"
- os: ubuntu-latest
python-version: "3.8"
steps:
- name: Checkout
Expand Down
4 changes: 1 addition & 3 deletions ipykernel/tests/test_message_spec.py
Original file line number Diff line number Diff line change
Expand Up @@ -509,9 +509,7 @@ def test_connect_request():
flush_channels()
msg = KC.session.msg("connect_request")
KC.shell_channel.send(msg)
return msg["header"]["msg_id"]

msg_id = KC.kernel_info()
msg_id = msg["header"]["msg_id"]
reply = get_reply(KC, msg_id, TIMEOUT)
validate_message(reply, "connect_reply", msg_id)

Expand Down

0 comments on commit 9970618

Please sign in to comment.