Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error opening new comm #1059

Closed
bollwyvl opened this issue Dec 16, 2022 · 8 comments · Fixed by #1056
Closed

Error opening new comm #1059

bollwyvl opened this issue Dec 16, 2022 · 8 comments · Fixed by #1056

Comments

@bollwyvl
Copy link
Contributor

With the 6.19.x line, i'm seeing this in this gist.

image

Rolling back to 6.17.1 does not show this behavior.

The target_name: "comm" is suspect. Having a further look, but this seemed like a useful minimum reproducer to explore further.

@bollwyvl
Copy link
Contributor Author

Some more data:

  • with 6.17.x, creating the slider results in 3 comm_open messages
    • all have the jupyter.widget target
  • with 6.19.x, the same generates 6 comm_open messages
    • 3 with comm target
    • 3 with jupyter.widget target

@maartenbreddels
Copy link
Contributor

Ouch, hope I don’t have to eat my laptop.
weird, because we had multiple confirmations 6.19.2 made widgets work.

@bollwyvl
Copy link
Contributor Author

yeah, dunno... but can confirm that pinning to !=6.19.* has unbroken some of my downstream CI jobs.

@maartenbreddels
Copy link
Contributor

Happy to take another look after the weekend, thanks for reporting!

@maartenbreddels
Copy link
Contributor

Sorry for this, this is caused a lot of pain already.

@maartenbreddels
Copy link
Contributor

@bollwyvl I think this is fixed in #1056 (comment) but I am not sure, since I cannot reproduce this :(

Could you try running that branch? Or maybe you have ideas on how to reproduce this locally.

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Dec 19, 2022

I've updated the gist with a git+https pointer to the head of that branch, and no longer see the problem. 🎉

image

@bollwyvl
Copy link
Contributor Author

I'm seeing some more issues... will try to create another reproducer and open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants