Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle tornado 6.1 on windows vs python 3.8 #563

Closed
bollwyvl opened this issue Dec 10, 2020 · 2 comments · Fixed by #564
Closed

handle tornado 6.1 on windows vs python 3.8 #563

bollwyvl opened this issue Dec 10, 2020 · 2 comments · Fixed by #564
Milestone

Comments

@bollwyvl
Copy link
Contributor

The good news: tornado 6.1 obviates the need for the nasty event loop hack.

The bad news: if the event loop hack is applied, it causes intermittent hanging at some deep dark level, and needs to be killed with non-python fire.

I've sprinkled a hard removal of the hack in a bunch of jupyter_server stuff, but feel like we might need to be a bit more cautious here.

I'm thinking of just adding if tornado.version_info >= (6, 1): continue to all of the hacks, as that API has been stable back to our bottom pin.

Also, it's about time to get off the travis-ci bus. GitHub actions seems like the right play, we've been fairly successful with it across a number of other repos.

PR incoming, but it might take a while (i'll try to get it green on a personal PR first).

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Dec 10, 2020

Here's my WIP PR: bollwyvl#1

@bollwyvl
Copy link
Contributor Author

I got green... going to squash'n'PR...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants