Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add github actions, bail on asyncio patch for tornado 6.1 #564

Merged
merged 1 commit into from
Dec 10, 2020

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Dec 10, 2020

This PR:

  • removes appveyor and travis
  • adds github actions
    • tests (py3.{6,7,8,9} + pypy) x {win,lin,mac}
      • couldn't even really get 3.5 going, not sure what's up
    • codecov
    • wheel caching
  • adds skips for some osx/pypy tests that just aren't working
    • we already skip them in conda-forge downstream
  • adds a version check for the tornado asyncio patch(es) on windows

Almost any of the excursions can flake, but at least they flake fast and hard instead of locking up until the CI reaps them for timeout.

Links:

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@blink1073 blink1073 merged commit b4bf5a2 into ipython:master Dec 10, 2020
@Zsailer
Copy link
Member

Zsailer commented Dec 10, 2020

This might warrant a quick patch release here. Things are a bit flaky in jupyter_server's CI and I think it's related to this issue.

@Zsailer
Copy link
Member

Zsailer commented Dec 10, 2020

BTW, thank you @bollwyvl!

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Dec 10, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

handle tornado 6.1 on windows vs python 3.8
4 participants