Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ipywidgets downstream test #1041

Closed
wants to merge 1 commit into from
Closed

Add ipywidgets downstream test #1041

wants to merge 1 commit into from

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 commented Nov 29, 2022 •
edited
Loading

Fixes #1040

@blink1073
Copy link
Contributor Author

To fix: AttributeError: Mock object has no attribute 'comm_id'

@blink1073
Copy link
Contributor Author

The following should work:

 from ipykernel.comm import Comm
mock_comm = MagicMock(spec=Comm)
assert mock_comm.comm_id

@maartenbreddels maartenbreddels mentioned this pull request Nov 29, 2022
Merged
@blink1073
Copy link
Contributor Author

Closing in favor of #1042

@blink1073 blink1073 closed this Nov 29, 2022
@blink1073 blink1073 deleted the add-widgets-downstream branch November 29, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Yank ipykernel 6.18.2 ?
1 participant
@blink1073