Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: too many arguments dropped when passing to base comm constructor #1051

Merged
merged 2 commits into from
Dec 8, 2022
Merged

fix: too many arguments dropped when passing to base comm constructor #1051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
514495a
fix: too many arguments dropped when passing to base comm constructor
maartenbreddels Dec 8, 2022
3cf49c8
simplify code
maartenbreddels Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ipykernel/comm/comm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,8 @@ def _default_comm_id(self):
def __init__(self, *args, **kwargs):
# Comm takes positional arguments, LoggingConfigurable does not, so we explicitly forward arguments
traitlets.config.LoggingConfigurable.__init__(self, **kwargs)
for name in self.trait_names():
if name in kwargs:
kwargs.pop(name)
# drop arguments not in BaseComm
kwargs.pop("kernel", None)
BaseComm.__init__(self, *args, **kwargs)


Expand Down
3 changes: 2 additions & 1 deletion ipykernel/tests/test_comm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ def test_comm(kernel):
manager = CommManager(kernel=kernel)
kernel.comm_manager = manager

c = Comm(kernel=kernel)
c = Comm(kernel=kernel, target_name="bar")
msgs = []

def on_close(msg):
Expand All @@ -23,6 +23,7 @@ def on_message(msg):
c.handle_close({})
c.close()
assert len(msgs) == 2
assert c.target_name == "bar"


def test_comm_manager(kernel):
Expand Down