-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check that sys.stdout/err is not None before flushing #344
Conversation
On windows this has been observed to be None at startup spyder-ide/spyder#7842
Thanks a lot @jenshnielsen! It looks good to me. |
Marking as 4.10, the current master branch have diverged from 4.x, so this will need a backport. |
Something went wrong ... Please have a look at my logs. |
@meeseeksdev backport to 4.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
branches were messed up, re-trying. |
@meeseeksdev backport to 4.x |
…on-4.x Backport PR #344 on branch 4.x (Check that sys.stdout/err is not None before flushing)
On Windows it seems that sys.stdout and possibly sys.stderr can be None.
This happens at startup of the kernel in Spyder e.g
spyder-ide/spyder#7842 and multiple duplicates.
The change to flush was introduced in 4.9 with #314
Checking that setout/stderr is not None before flushing seems to be enough to fix the issue for me.