Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flush after sending replies #390

Merged
merged 1 commit into from
May 16, 2019
Merged

Conversation

minrk
Copy link
Member

@minrk minrk commented Feb 20, 2019

to ensure that the reply is actually sent before we handle the next request

closes #389
closes jupyter/notebook#2748
closes jupyter/notebook#4334

cc @stas00

to ensure that the reply is actually sent before we handle the next request
@stas00
Copy link

stas00 commented Feb 20, 2019

Yay! That does fix the problem in the nb that was reproducing it. Thank you so much, @minrk!

@stas00
Copy link

stas00 commented Mar 1, 2019

Are there any obstacles to merging this fix, @minrk?

@stas00
Copy link

stas00 commented Mar 29, 2019

Any reason why this fix doesn't get merged, anybody?

@noklam
Copy link

noklam commented May 16, 2019

Hi, could someone merge this fix?

@blink1073
Copy link
Contributor

LGTM

@blink1073 blink1073 merged commit 5e72a64 into ipython:master May 16, 2019
@blink1073
Copy link
Contributor

Released to PyPI as 5.1.1, conda-forge pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment