Fix Heartbeat._bind_socket to return on the first successful bind. #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdickinson
commented
Sep 12, 2019
ipykernel/tests/test_heartbeat.py
Outdated
| @@ -21,6 +21,14 @@ def test_port_bind_failure_raises(): | |||
| assert mock_try_bind.call_count == 1 | |||
|
|
|||
|
|
|||
| def test_port_bind_failure_succeeds(): | |||
There was a problem hiding this comment.
Aargh; that's a bad test name. I'll fix to remove the "failure" text.
mdickinson
commented
Sep 12, 2019
ipykernel/tests/test_heartbeat.py
Outdated
| def test_port_bind_failure_succeeds(): | ||
| heart = Heartbeat(None) | ||
| with patch.object(heart, '_try_bind_socket') as mock_try_bind: | ||
| mock_try_bind.side_effect = lambda: None |
There was a problem hiding this comment.
This line could probably just be removed.
|
LGTM, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
Heartbeat._bind_socketcode so that it returns on the first successful bind; it also adds a regression test.Fixes #430.