Rework wait_for_ready logic #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbrochart
force-pushed
the
fix_inprocess
branch
from
23a6163
to
9b47377
Compare
davidbrochart
force-pushed
the
fix_inprocess
branch
from
9b47377
to
a6a68b6
Compare
ccordoba12
reviewed
Jan 11, 2021
| @@ -97,6 +97,7 @@ def run(self): | |||
| 'pytest-cov', | |||
| 'flaky', | |||
| 'nose', # nose because there are still a few nose.tools imports hanging around | |||
| 'jedi<=0.17.2' | |||
There was a problem hiding this comment.
Eventually yes, but the tests were failing without that.
There was a problem hiding this comment.
I'm aware of this, but I'm swamped and haven't had a chance to look at IPython since mid december, I know there are a bunch of issues and PRs I need o review/fix/merge.
There was a problem hiding this comment.
@davidbrochart - can we add a comment to the effect here, so that we know later when we can remove the pin?
There was a problem hiding this comment.
Done in #579
|
@meeseeksdev please backport to 5.4.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/ipykernel
that referenced
this pull request
Jan 11, 2021
blink1073
added a commit
that referenced
this pull request
Jan 11, 2021
…on-5.4.x Backport PR #578 on branch 5.4.x (Rework wait_for_ready logic)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the same logic as in jupyter_client.
Closes jupyter/jupyter_client#601