Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented inspectVariables request #624

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Implemented inspectVariables request #624

merged 1 commit into from
Mar 30, 2021

Conversation

JohanMabille
Copy link
Contributor

This PR implements the inspectVariables request handling in ipykernel, which was the last missing debug request.

@blink1073 blink1073 added this to the 6.0 milestone Mar 30, 2021
@blink1073
Copy link
Contributor

Is this ready for review?

@JohanMabille
Copy link
Contributor Author

Yes

blink1073
blink1073 approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit dc35b1e into ipython:master Mar 30, 2021
@JohanMabille JohanMabille deleted the inspect branch March 31, 2021 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JohanMabille @blink1073