Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ipykernel #799 by removing publish_status in process_control #819

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mizililo
Copy link

@mizililo mizililo commented Dec 3, 2021

because control_channel shouldn't publish execution_state

@JohanMabille
Copy link
Contributor

JohanMabille commented Dec 3, 2021

I think we should wait before merging this. I have opened a JEP to move the kernel_info_request to the control channel to fix jupyterlab/jupyterlab#10174, and the jupyter server expects both a reply to the kernel_info_reply and a message on IOPub to cosider it has connected to the kernel. Merging this PR would break the new behavior.

Notice there is a on-going JEP to replace PUB socket with XPUB socket, so that clients get an iopub message upon connection and they don't have to nudge the kernel anymore.

@mizililo
Copy link
Author

mizililo commented Dec 7, 2021

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants