Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handled AllThreadsContinued and workaround for wrong threadId in cont… #844

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

JohanMabille
Copy link
Contributor

…inued event after a next request

This PR adds correct handling of allThreadsContinued attribute of continued event. Besides, it workarounds a bug of debugpy/pydev where the threadId attribute of the continued event is not correct after a next request. Notice the workaround is working only if a single thread is executed on the shell.

This bug results in the weird behavior noticed in Lab. An issue has been opened on the debugpy repo.

@blink1073 blink1073 added the bug label Jan 17, 2022
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit d9243ee into ipython:main Jan 17, 2022
@JohanMabille JohanMabille deleted the continued_event branch January 28, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants