-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the PID to the resource usage reply #908
Add the PID to the resource usage reply #908
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@meeseeksdev please run pre-commit |
Would you mind installing me on your fork so that I can update your branch? |
@blink1073 Do I need to do that? :)
From https://results.pre-commit.ci/run/github/33655535/1649143235.UlgrmZ1WTxqnlHNozV_lAg
|
@meeseeksdev please run pre-commit |
Would you mind installing me on your fork so that I can update your branch? |
Yes, that message is for you, but the bot also had a bug that I just fixed. |
Okay, now it is getting a 403, so it looks like you do need to enable it. |
Ohh, you don't have maintainer edits enabled. That explains why pre-commit-ci bot didn't just do it. |
Should someone give me maintainer edits, or should I install Meeseeksdev on my org. Is there a way to only install Meeseeksdev on one repo of the org (the scope of permissions is fairly large, I would prefer be immune to any misbehavior of Meeseeksdev, you know bugs happen). |
You can enable maintainer edits on this page, should be a checkbox in the top right area. AFAIK you can install any app on a per-repo basis. |
I am hitting community/community#5634 (the fork lives in a org, so the maintainer edits option is not possible for now if I understand correctly). I have now installed meeseeksdev app in the fork. |
@meeseeksdev please run pre-commit |
@datalayer-externals, would you mind installing me on your fork so that I can update your branch? |
I was unable to push due to errors |
I've applied "pre-commit" and pushed. You may have trouble pushing further |
meseeksdev says |
Another bug, fixing now |
Fixes #907