Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the PID to the resource usage reply #908

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

echarles
Copy link
Member

@echarles echarles commented Apr 5, 2022

Fixes #907

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blink1073
Copy link
Contributor

@meeseeksdev please run pre-commit

@lumberbot-app
Copy link

lumberbot-app bot commented Apr 5, 2022

Would you mind installing me on your fork so that I can update your branch?
Click here to do that, and follow the instructions to add your fork.I'm going to try to push as a maintainer but this may not work.

@echarles
Copy link
Member Author

echarles commented Apr 5, 2022

@blink1073 Do I need to do that? :)

Read access to administration, commit statuses, members, metadata, organization projects, and repository projects
Read and write access to code, deployments, issues, pages, and pull requests

Screenshot 2022-04-05 at 11 23 34

From https://results.pre-commit.ci/run/github/33655535/1649143235.UlgrmZ1WTxqnlHNozV_lAg black is failing.

black....................................................................Failed
- hook id: black
- files were modified by this hook
```

So I have run `black` on the sources and got a lot of changes. Maybe I need to run with a specific config?

@blink1073
Copy link
Contributor

@meeseeksdev please run pre-commit

@lumberbot-app
Copy link

lumberbot-app bot commented Apr 5, 2022

Would you mind installing me on your fork so that I can update your branch?
Click here to do that, and follow the instructions to add your fork.I'm going to try to push as a maintainer but this may not work.

@blink1073
Copy link
Contributor

Yes, that message is for you, but the bot also had a bug that I just fixed.

@blink1073
Copy link
Contributor

Okay, now it is getting a 403, so it looks like you do need to enable it.

@blink1073
Copy link
Contributor

Ohh, you don't have maintainer edits enabled. That explains why pre-commit-ci bot didn't just do it.

@echarles
Copy link
Member Author

echarles commented Apr 5, 2022

Ohh, you don't have maintainer edits enabled. That explains why pre-commit-ci bot didn't just do it.

Should someone give me maintainer edits, or should I install Meeseeksdev on my org. Is there a way to only install Meeseeksdev on one repo of the org (the scope of permissions is fairly large, I would prefer be immune to any misbehavior of Meeseeksdev, you know bugs happen).

@blink1073
Copy link
Contributor

You can enable maintainer edits on this page, should be a checkbox in the top right area. AFAIK you can install any app on a per-repo basis.

@echarles
Copy link
Member Author

echarles commented Apr 5, 2022

I am hitting community/community#5634 (the fork lives in a org, so the maintainer edits option is not possible for now if I understand correctly).

I have now installed meeseeksdev app in the fork.

@blink1073
Copy link
Contributor

@meeseeksdev please run pre-commit

@lumberbot-app
Copy link

lumberbot-app bot commented Apr 5, 2022

@datalayer-externals, would you mind installing me on your fork so that I can update your branch?
Click here to do that, and follow the instructions to add your fork. I'm going to try to push as a maintainer but this may not work.

@lumberbot-app
Copy link

lumberbot-app bot commented Apr 5, 2022

I was unable to push due to errors

@lumberbot-app
Copy link

lumberbot-app bot commented Apr 5, 2022

I've applied "pre-commit" and pushed. You may have trouble pushing further
commits, but feel free to force push and ask me to run again.

@echarles
Copy link
Member Author

echarles commented Apr 5, 2022

meseeksdev says I've applied "pre-commit" and pushed but I don't see any commits. So I have run black --line-length=100 . and committed/pushed the change.

@blink1073
Copy link
Contributor

meseeksdev says I've applied "pre-commit" and pushed but I don't see any commits

Another bug, fixing now

@blink1073 blink1073 merged commit 3130a2e into ipython:main Apr 5, 2022
@echarles
Copy link
Member Author

echarles commented Apr 5, 2022

👍 @blink1073

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PID to the resource usage reply
2 participants