Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pss memory info type if available for the resource usage reply #948

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

echarles
Copy link
Member

@echarles echarles commented Jun 6, 2022

Fixes #935

@echarles
Copy link
Member Author

echarles commented Jun 8, 2022

@nishikantparmariam

@nishikantparmariam
Copy link

This looks good to me.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 added the bug label Jun 13, 2022
@blink1073
Copy link
Contributor

Ah, @echarles this picked up conflicts and needs a pre-commit run.

@blink1073
Copy link
Contributor

I'll hold off on making the release for now.

@blink1073 blink1073 merged commit 2695697 into ipython:main Jun 13, 2022
@echarles
Copy link
Member Author

@blink1073 conflicts are now resolved. I see it is now merged. Thx and happy release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing memory calculation methodology from RSS to PSS
3 participants