Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electric backspace #5

Closed
ryanprior opened this issue Nov 15, 2015 · 2 comments
Closed

electric backspace #5

ryanprior opened this issue Nov 15, 2015 · 2 comments

Comments

@ryanprior
Copy link

If you see an emoji, you don't necessarily know how many backspaces it'll take to delete it. Could be just one for a Unicode emoji or many for a github-style one. We can eliminate this uncertainty by advising delete to remove the whole emoji, regardless of how many literal characters it contains.

@iqbalansari
Copy link
Owner

This sounds like a useful feature. I will work on this once the existing bugs are resolved.

In terms of implementation I think advising delete would be tricky since there are multiple ways in which text can be deleted (one example in sp-delete-char) perhaps we can simply advice delete-char but advises can be tricky as such I try to avoid them if possible.

One approach would be to add a local keymap for emoji text.

iqbalansari pushed a commit that referenced this issue Nov 19, 2015
iqbalansari pushed a commit that referenced this issue Nov 19, 2015
@iqbalansari
Copy link
Owner

Hi,

I have implemented this on master. Please give it a try when MELPA builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants