Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple emoji in sequence #6

Closed
ryanprior opened this issue Nov 15, 2015 · 4 comments
Closed

multiple emoji in sequence #6

ryanprior opened this issue Nov 15, 2015 · 4 comments
Labels

Comments

@ryanprior
Copy link

":100: 😄" is converted into two emojis, but ":100:😄" with no whitespace between is left untouched. Similarly, ":100:abcdef😄" is left untouched. The desired behavior should convert to emojis in all these cases.

@iqbalansari
Copy link
Owner

That is because the package is very conservative about displaying emojis. This was done mainly to avoid cases where plain ascii emojis can appear in a word for example d: in head:. Thinking about it again I think it is very restrictive perhaps we can do those checks only for ascii emojis. What do you think?

@ryanprior
Copy link
Author

If it was me, I would turn off ASCII emojis by default. Only in certain contexts (chatrooms or twittering-mode, for example) would I be tempted to turn them on. Otherwise emojifying them just isn't that useful, as they're pretty much homoiconic. We might offer something in the customize interface that lets you set styles depending on the mode.

For github-style emojis, it's a slightly harder call. For example, if you're trying to write a colon-separated list like lang=de:us:se:es:jp but emojify turns that into lang=de:us:se:es:jp, then that's maybe annoying. But the cases like that you run into are going to be few compared to the ASCII style.

For unicode emojis, I don't see any benefit to being conservative. We can afford to aggressively emojify those.

@iqbalansari
Copy link
Owner

Should be better on latest master. Please do report back if it works properly or if you face any additional issues. Thanks

@iqbalansari
Copy link
Owner

Hi,

I am closing this. Please feel free to open further issues if you face any problems.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants