component: Use generational-arena for component storage
#113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `generational-arena` crate implements a generational index allocator which provides a "weak ref" for addressing a particular component, implemented in this PR in the form of `component::Handle`: <https://github.com/fitzgen/generational-arena> This also allows multiple simultaneous mutable references to components, so this PR additionally introduces `Component::register_dependency` which provides mutable refs to a component and its dependency for each enumerated dependency. In principle this is equivalent to "dependency injection". This PR removes the previous downcasting functionality, which was never tested and didn't seem to work out in practice. It should get added back, but in a form that actually works, with tests.
tarcieri
force-pushed
the
component-arena
branch
from
d15c147
to
4d067fb
Compare
|
@lberezy this PR might help address some of your concerns (although not all of them). I intend to backfill some tests after this, but hopefully this is closer to where the component system should be. This removes the previously useless downcasting functionality. I'd like to bring it back, but with tests to ensure it's actually useful. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
generational-arenacrate implements a generational index allocator which provides a "weak ref" for addressing a particular component, implemented in this PR in the form ofcomponent::Handle:https://github.com/fitzgen/generational-arena
This also allows multiple simultaneous mutable references to components, so this PR additionally introduces
Component::register_dependencywhich provides mutable refs to a component and its dependency for each enumerated dependency. In principle this is equivalent to "dependencyinjection".
This PR removes the previous downcasting functionality, which was never tested and didn't seem to work out in practice. It should get added back, but in a form that actually works, with tests.